On 07/07/2024, Krzysztof Kozlowski wrote: > On 05/07/2024 11:09, Liu Ying wrote: >> Freescale i.MX8qxp Display Controller is implemented as construction set of >> building blocks with unified concept and standardized interfaces. >> >> Document some processing units to support two display outputs. > > >> +maintainers: >> + - Liu Ying <victor.liu@xxxxxxx> >> + >> +properties: >> + compatible: >> + const: fsl,imx8qxp-dc-tcon >> + >> + reg: >> + maxItems: 1 >> + >> + fsl,dc-tc-id: >> + description: Timing Controller unit instance number > > No instance numbering. This applies to your entire patchset. Then, I'll call of_alias_get_id() from the drivers to get instance number instead. As i.MX8qm SoC embeds two Display Controllers, the alias stem would contain the Display Controller instance number, like "dc0-tcon" and "dc1-tcon". Is this ok? > > > > Best regards, > Krzysztof > > -- Regards, Liu Ying