On Tue, 2 Jul 2024 17:29:14 +0200, Javier Carrasco wrote: > Hi Abhinav, > > Apart form having sent two different patches with the same title (hence > the confusion), this cleanup is right from a functional point of view. > > On the other hand, the description should address why you are doing this > cleanup (e.g. to remove the need for explicit of_node_put() when the > variable goes out of scope). The need for of_node_put() does no vanish, > it is only automated and no longer visible at first glance by means of > the cleanup attribute. > > Best regards, > Javier Carrasco Hi Javier, Thank you for the detailed feedback. I have modified the patch subject as well as the commit description to better fit the cleanup task being done. PATCH v2: https://lore.kernel.org/all/20240704132142.1003887-1-jain.abhinav177@xxxxxxxxx/ Best Regards, Abhinav Jain
