Hi
Am 28.06.24 um 12:09 schrieb Jocelyn Falempe:
On 27/06/2024 17:27, Thomas Zimmermann wrote:
The CRTC's mode-setting code contains quite a bit of code that
belongs to the planes or various encoder chips. This patchset
refactors these bits and moves things to the correct places.
With the patches applied, the remaining DPMS function will be
gone and its content be moved. Several code duplications will
be removed. There was also a bugfix wrt the VGA SCREEN_DISABLE
bit, but it's unclear if the bug had any effect in practice.
Tested with AST2100 and AST2600 with VGA and DP outputs.
Thanks,
I've tested the patch series, on a remote ampere (aarch64) system with
AST 2500, and it works. I wasn't able to test with a real monitor
attached.
Ok, so the BMC also still works. Thanks for reviewing and testing.
I've long wanted to clean up this code. Earlier his week I got a monitor
working on the AST2600's DP port. So I could finally test these
refactorings. With this in place, there's more to come to improve the
driver's output code.
Best regards
Thomas
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
