On Fri, Jun 14, 2024 at 3:59 PM Danila Tikhonov <danila@xxxxxxxxxxx> wrote: > > Document the MDSS hardware found on the Qualcomm SM7150 platform. > > Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- > .../display/msm/qcom,sm7150-mdss.yaml | 458 ++++++++++++++++++ > 1 file changed, 458 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml > new file mode 100644 > index 0000000000000..13c5d5ffabde9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml > @@ -0,0 +1,458 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/msm/qcom,sm7150-mdss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm SM7150 Display MDSS > + > +maintainers: > + - Danila Tikhonov <danila@xxxxxxxxxxx> > + > +description: > + SM7150 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like > + DPU display controller, DSI and DP interfaces etc. > + > +$ref: /schemas/display/msm/mdss-common.yaml# > + > +properties: > + compatible: > + const: qcom,sm7150-mdss > + > + clocks: > + items: > + - description: Display ahb clock from gcc > + - description: Display hf axi clock > + - description: Display sf axi clock > + - description: Display core clock > + > + clock-names: > + items: > + - const: iface > + - const: bus > + - const: nrt_bus > + - const: core > + > + iommus: > + maxItems: 1 > + > + interconnects: > + items: > + - description: Interconnect path from mdp0 port to the data bus > + - description: Interconnect path from mdp1 port to the data bus > + - description: Interconnect path from CPU to the reg bus > + > + interconnect-names: > + items: > + - const: mdp0-mem > + - const: mdp1-mem > + - const: cpu-cfg > + > +patternProperties: > + "^display-controller@[0-9a-f]+$": > + type: object > + additionalProperties: true > + properties: > + compatible: > + const: qcom,sm7150-dpu > + > + "^displayport-controller@[0-9a-f]+$": > + type: object > + additionalProperties: true > + properties: > + compatible: > + const: qcom,sm7150-dp > + > + "^dsi@[0-9a-f]+$": > + type: object > + additionalProperties: true > + properties: > + compatible: > + items: > + - const: qcom,sm7150-dsi-ctrl > + - const: qcom,mdss-dsi-ctrl You've added this compatible, but haven't updated the corresponding schema. With a recent change to dtschema fixing a regression, we get warnings about it: /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.example.dtb: dsi@ae94000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sm7150-dsi-ctrl', 'qcom,mdss-dsi-ctrl'] is too long 'qcom,sm7150-dsi-ctrl' is not one of ['qcom,apq8064-dsi-ctrl', 'qcom,msm8226-dsi-ctrl', 'qcom,msm8916-dsi-ctrl', 'qcom,msm8953-dsi-ctrl', 'qcom,msm8974-dsi-ctrl', 'qcom,msm8976-dsi-ctrl', 'qcom,msm8996-dsi-ctrl', 'qcom,msm8998-dsi-ctrl', 'qcom,qcm2290-dsi-ctrl', 'qcom,sc7180-dsi-ctrl', 'qcom,sc7280-dsi-ctrl', 'qcom,sdm660-dsi-ctrl', 'qcom,sdm670-dsi-ctrl', 'qcom,sdm845-dsi-ctrl', 'qcom,sm6115-dsi-ctrl', 'qcom,sm6125-dsi-ctrl', 'qcom,sm6350-dsi-ctrl', 'qcom,sm6375-dsi-ctrl', 'qcom,sm8150-dsi-ctrl', 'qcom,sm8250-dsi-ctrl', 'qcom,sm8350-dsi-ctrl', 'qcom,sm8450-dsi-ctrl', 'qcom,sm8550-dsi-ctrl', 'qcom,sm8650-dsi-ctrl'] 'qcom,sm7150-dsi-ctrl' is not one of ['qcom,dsi-ctrl-6g-qcm2290', 'qcom,mdss-dsi-ctrl'] from schema $id: http://devicetree.org/schemas/display/msm/dsi-controller-main.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.example.dtb: dsi@ae94000: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/display/msm/dsi-controller-main.yaml# Either you need to drop this node from here (and the example) or update the DSI schema. Rob