Hi Thomas, On Thu, Jun 20, 2024 at 10:20 PM Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx> wrote: > > Hi, Chen-Yu: > > Chen-Yu Tsai <wenst@xxxxxxxxxxxx> 於 2024年6月20日 週四 下午1:47寫道: > > > > With the recent switch from fbdev-generic to fbdev-dma, the driver now > > requires the DRM GEM DMA helpers. This dependency is missing, and will > > cause a link failure if fbdev emulation is enabled. > > > > Add the missing dependency. > > Acked-by: Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxxxx> Could you help merge this? Thanks ChenYu > > > > Fixes: 0992284b4fe4 ("drm/mediatek: Use fbdev-dma") > > Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > > --- > > The commit this patch fixes is in drm-misc-next. Ideally this patch > > should be applied on top of it directly. > > > > CK, could you give your ack for it? > > > > drivers/gpu/drm/mediatek/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > > index 96cbe020f493..d6449ebae838 100644 > > --- a/drivers/gpu/drm/mediatek/Kconfig > > +++ b/drivers/gpu/drm/mediatek/Kconfig > > @@ -7,6 +7,7 @@ config DRM_MEDIATEK > > depends on HAVE_ARM_SMCCC > > depends on OF > > depends on MTK_MMSYS > > + select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION > > select DRM_KMS_HELPER > > select DRM_MIPI_DSI > > select DRM_PANEL > > -- > > 2.45.2.741.gdbec12cfda-goog > >