On Tue, 25 Jun 2024 at 18:02, Maxime Ripard <mripard@xxxxxxxxxx> wrote: > > Hi, > > On Sun, Jun 23, 2024 at 08:40:12AM GMT, Dmitry Baryshkov wrote: > > On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI > > IGT chokes on the max_bpc property in several kms_properties tests due > > to the the drm_bridge_connector failing to reset HDMI-related > > properties. > > > > Call __drm_atomic_helper_connector_hdmi_reset() if there is a > > the drm_bridge_connector has bridge_hdmi. > > > > Note, the __drm_atomic_helper_connector_hdmi_reset() is moved to > > drm_atomic_state_helper.c because drm_bridge_connector.c can not depend > > on DRM_DISPLAY_HDMI_STATE_HELPER. At the same time it is impossible to > > call this function from HDMI bridges, there is is no function that > > corresponds to the drm_connector_funcs::reset(). > > Why can't it depend on DRM_DISPLAY_HDMI_STATE_HELPER? Is it okay to have DRM_KMS_HELPER to depend unconditionally or select DRM_DISPLAY_HDMI_STATE_HELPER? -- With best wishes Dmitry
