On Mon, 24 Jun 2024 at 14:33, Caleb Connolly <caleb@xxxxxxxxxxxxxxxx> wrote: > > > > On 24/06/2024 07:18, Dmitry Baryshkov wrote: > > On Mon, Jun 24, 2024 at 03:30:24AM GMT, Caleb Connolly wrote: > >> Add bindings for the SM8250 OnePlus devices, a common devicetree, > >> touchscreen and display drivers, and a dts for the OnePlus 8T (kebab). > >> > >> The OnePlus 8 series is made up of 3 flagship smartphones from 2019, > >> featuring the Qualcomm X55 5G PCIe modem. > >> > >> This series introduces initial support for the 8T, adding drivers for > >> the 1080x2400 120Hz DSC panel and the Synaptics TCM Oncell touchscreen. > >> > >> The panel driver suffers from similar limitations to the LG SW43408 > >> panel found on the Pixel 3, namely that after toggling the reset GPIO it > >> is not possible to get the panel into a working state. > > > > Just to point it out: this is no longer true for SW43408. The panel > > wakes up and works after toggling the reset. It seems, there is an issue > > with one of the regulators, but not with the reset and/or panel startup. > > Hmm ok, I've heard mixed reports then, I should try it out myself again. During MAD24 we have seen an issue with the regulators, when the panel doesn't wake up. But resetting the panel works. > > I'll update the cover letter to reflect this. Thanks. > > > >> Given the apparent prevelance of this issue, particularly with DSC > >> panels, I believe this is a bug in the core DSI code, and not a device > >> or panel specific issue. I think it is still useful to accept these > >> panel drivers into upstream since, from a users perspective, the panel > >> is fully functional just by leaving the reset GPIO alone and keeping the > >> regulator on. The only (theoretical) downside is worse battery life, > >> which is a small price to pay for a working display. > >> > > -- With best wishes Dmitry
