On Sun, Jun 23, 2024 at 07:17:04AM GMT, Keith Zhao wrote: > > On Tue, May 21, 2024 at 06:58:14PM +0800, keith wrote: > > > add crtc funs and helper funs > > > > > > Signed-off-by: keith <keith.zhao@xxxxxxxxxxxxxxxx> > > > --- > > > drivers/gpu/drm/verisilicon/Makefile | 3 +- > > > drivers/gpu/drm/verisilicon/vs_crtc.c | 241 > > > ++++++++++++++++++++++++++ drivers/gpu/drm/verisilicon/vs_crtc.h | > > > 17 ++ > > > 3 files changed, 260 insertions(+), 1 deletion(-) create mode 100644 > > > drivers/gpu/drm/verisilicon/vs_crtc.c > > > create mode 100644 drivers/gpu/drm/verisilicon/vs_crtc.h > > > > > > diff --git a/drivers/gpu/drm/verisilicon/vs_crtc.h > > > b/drivers/gpu/drm/verisilicon/vs_crtc.h > > > new file mode 100644 > > > index 000000000000..b1e588bb780d > > > --- /dev/null > > > +++ b/drivers/gpu/drm/verisilicon/vs_crtc.h > > > @@ -0,0 +1,17 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > +/* > > > + * Copyright (C) 2023 VeriSilicon Holdings Co., Ltd. > > > + */ > > > + > > > +#ifndef __VS_CRTC_H__ > > > +#define __VS_CRTC_H__ > > > + > > > +#include <drm/drm_crtc.h> > > > +#include <drm/drm_crtc_helper.h> > > > > Do you really need to include them here? > > > The location of include can be optimized > Delete #include <drm/drm_crtc.h> > Move drm_crtc_helper.h to vs_crtc.c Yes, please. > > > > + > > > +#include "vs_drv.h" > > > + > > > +struct vs_crtc *vs_crtc_create(struct drm_device *drm_dev, > > > + struct vs_dc_info *info); This prototype needs #include <drm_device.h>, not drm_crtc*. Or even better drop the include completely and just formward-declare the structure: struct drm_device; struct vs_crtc *vs_crtc_create(struct drm_device *drm_dev, struct vs_dc_info *info); > > > + > > > +#endif /* __VS_CRTC_H__ */ > > > -- > > > 2.27.0 > > > > > > > -- > > With best wishes > > Dmitry -- With best wishes Dmitry
