Re: [PATCH 00/31] Preparatory patches for BCM2712 (Pi5) support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dave,

Thanks for taking the time to send this.

I've gone through most of the patches and it looks pretty good already,
but I have a few general remarks:

  - We merged in drm-misc-next the new HDMI infrastructure recently and
    it will heavily conflict with some of these patches, so you need to
    rebase against either linux-next or drm-misc-next.

  - The author and SoB fields for my patches don't match anymore,
    possibly due to mailmap doing its magic.

    You can fix this by using, for the SoB:
    git filter-branch --msg-filter 'sed -i s/maxime@xxxxxxxxxx/mripard@xxxxxxxxxx/' drm-misc-next..

    And for the authorship:
    git commit --amend --author="Maxime Ripard <mripard@xxxxxxxxxx>"
    for each commit.

  - All of the fixes need Fixes that are currently missing on most tags

  - And the commit prefix isn't consistent, especially for vc4_plane.c,
    the upstream convention so far has been drm/vc4: plane, instead of
    drm/vc4_plane.

Maxime

On Thu, Jun 20, 2024 at 04:46:01PM GMT, Dave Stevenson wrote:
> Hi
> 
> This set is a number of minor fixes that we've had downstream for a while,
> and then lays down the some infrastructure changes to facilitate adding support
> of BCM2712. I'm just finalising those patches so they should follow on fairly
> soon.
> 
> Thanks
>   Dave
> 
> Dave Stevenson (8):
>   drm/vc4: Force trigger of dlist update on margins change
>   drm/vc4: Set AXI panic modes for the HVS
>   drm/vc4: Limit max_bpc to 8 on Pi0-3
>   drm/vc4: Don't write gamma luts on 2711
>   drm/vc4: UV planes vertical scaling must always be enabled
>   drm/vc4: Fix dlist debug not resetting the next entry pointer
>   drm/vc4: Remove incorrect limit from hvs_dlist debugfs function
>   drm/vc4: Move the buffer offset out of the vc4_plane_state
> 
> Dom Cobley (7):
>   drm/vc4: vc4_plane: Keep fractional source coords inside state
>   drm/vc4: Handle fractional coordinates using the phase field
>   drm/vc4: hdmi: Avoid log spam for audio start failure
>   drm/vc4_plane: Add support for YUV444 formats
>   drm/vc4: hdmi: Increase audio MAI fifo dreq threshold
>   drm/vc4: hdmi: Avoid hang with debug registers when suspended
>   drm/vc4: hvs: Remove ABORT_ON_EMPTY flag
> 
> Maxime Ripard (15):
>   drm/vc4: hdmi: Warn if writing to an unknown HDMI register
>   drm/vc4: hvs: More logging for dlist generation
>   drm/vc4: hvs: Print error if we fail an allocation
>   drm/vc4: plane: Add more debugging for LBM allocation
>   drm/vc4: plane: Use return variable in atomic_check
>   drm/vc4: crtc: Move assigned_channel to a variable
>   drm/vc4: Introduce generation number enum
>   drm/vc4: Make v3d paths unavailable on any generation newer than vc4
>   drm/vc4: hvs: Use switch statement to simplify
>     vc4_hvs_get_fifo_from_output
>   drm/vc4: hvs: Create hw_init function
>   drm/vc4: hvs: Create cob_init function
>   drm/vc4: hvs: Rename hvs_regs list
>   drm/vc4: plane: Change ptr0_offset to an array
>   drm/vc4: hvs: Rework LBM alignment
>   drm/vc4: hvs: Change prototype of __vc4_hvs_alloc to pass registers
> 
> Tim Gover (1):
>   drm/vc4: Enable SCALER_CONTROL early in HVS init
> 
>  drivers/gpu/drm/vc4/tests/vc4_mock.c       |  14 +-
>  drivers/gpu/drm/vc4/vc4_bo.c               |  28 +-
>  drivers/gpu/drm/vc4/vc4_crtc.c             |  35 ++-
>  drivers/gpu/drm/vc4/vc4_drv.c              |  22 +-
>  drivers/gpu/drm/vc4/vc4_drv.h              |  29 +-
>  drivers/gpu/drm/vc4/vc4_gem.c              |  24 +-
>  drivers/gpu/drm/vc4/vc4_hdmi.c             |  30 +-
>  drivers/gpu/drm/vc4/vc4_hdmi_regs.h        |   5 +-
>  drivers/gpu/drm/vc4/vc4_hvs.c              | 343 +++++++++++++--------
>  drivers/gpu/drm/vc4/vc4_irq.c              |  10 +-
>  drivers/gpu/drm/vc4/vc4_kms.c              |  14 +-
>  drivers/gpu/drm/vc4/vc4_perfmon.c          |  20 +-
>  drivers/gpu/drm/vc4/vc4_plane.c            | 281 +++++++++++------
>  drivers/gpu/drm/vc4/vc4_regs.h             |   1 +
>  drivers/gpu/drm/vc4/vc4_render_cl.c        |   2 +-
>  drivers/gpu/drm/vc4/vc4_v3d.c              |  10 +-
>  drivers/gpu/drm/vc4/vc4_validate.c         |   8 +-
>  drivers/gpu/drm/vc4/vc4_validate_shaders.c |   2 +-
>  18 files changed, 540 insertions(+), 338 deletions(-)
> 
> -- 
> 2.34.1
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux