On Thu, Jun 20, 2024 at 01:27:15PM GMT, Abhinav Kumar wrote: > > > On 6/7/2024 6:23 AM, Dmitry Baryshkov wrote: > > The mode_set callback is deprecated, it doesn't get the > > drm_bridge_state, just mode-related argumetns. Turn it into the > > atomic_enable callback as suggested by the documentation. > > > > mode_set is deprecated but atomic_mode_set is not. There is no atomic_mode_set() in drm_bridge_funcs. Also: * This is deprecated, do not use! * New drivers shall set their mode in the * &drm_bridge_funcs.atomic_enable operation. > > I would rather use atomic_mode_set because moving to atomic_enable() would > be incorrect. > > That would be called after encoder's enable and hence changes the sequence. > That was not the intention of this patch. > > NAK. > > > Acked-by: Maxime Ripard <mripard@xxxxxxxxxx> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > > drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 33 ++++++++++++++++++++++++++------- > > 1 file changed, 26 insertions(+), 7 deletions(-) -- With best wishes Dmitry
