On Wed, May 29, 2024 at 3:41 AM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>
> On 28.05.2024 9:43 PM, Barnabás Czémán wrote:
> > From: Otto Pflüger <otto.pflueger@xxxxxxxxx>
> >
> > Add support for Adreno 306A GPU what is found in MSM8917 SoC.
> > This GPU marketing name is Adreno 308.
> >
> > Signed-off-by: Otto Pflüger <otto.pflueger@xxxxxxxxx>
> > [use internal name of the GPU, reword the commit message]
> > Signed-off-by: Barnabás Czémán <trabarni@xxxxxxxxx>
> > ---
>
> [...]
>
>
> >
> > +static inline bool adreno_is_a306a(const struct adreno_gpu *gpu)
> > +{
> > + /* a306a marketing name is a308 */
> > + return adreno_is_revn(gpu, 308);
> > +}
>
> The .c changes look good. Rob, do we still want .rev nowadays?
mostly I just want to avoid revn for newer GPUs, but I suppose we
should be consistent and drop it for "new old" GPUs..
Also, it would be nice to rebase on
https://patchwork.freedesktop.org/series/127393/
BR,
-R
