On 18/06/2024 15:59, Dzmitry Sankouski wrote: > Add driver for Maxim 77705 switch-mode charger (part of max77705 > MFD driver) providing power supply class information to userspace. > > The driver is configured through DTS (battery and system related > settings). Also, POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE property > is writable, which allows to configure charge end at less than 100% > ... > + * > + * Copyright (C) 2015 Samsung Electronics, Inc. > + * > + * > + * This software is licensed under the terms of the GNU General Public > + * License version 2, as published by the Free Software Foundation, and > + * may be copied, distributed, and modified under those terms. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. Yeah, please do not upstream 2015 Samsung code. Instead, take a new, clean, decent driver and use it as template. Otherwise you ask us to do exactly the same review we already gave last 10 years. Or review on issues we fixed last 10 years. Best regards, Krzysztof