On Wed, 19 Jun 2024 at 09:45, Ekansh Gupta <quic_ekangupt@xxxxxxxxxxx> wrote: > > > > On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: > > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: > >> Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > >> to be added for PD notifications and other missing features. Adding > >> and maintaining new files from within fastrpc directory would be easy. > >> > >> Example of feature that is being planned to be introduced in a new C > >> file: > >> https://lore.kernel.org/all/20240606165939.12950-6-quic_ekangupt@xxxxxxxxxxx/ > >> > >> Signed-off-by: Ekansh Gupta <quic_ekangupt@xxxxxxxxxxx> > >> --- > >> MAINTAINERS | 2 +- > >> drivers/misc/Kconfig | 13 +------------ > >> drivers/misc/Makefile | 2 +- > >> drivers/misc/fastrpc/Kconfig | 16 ++++++++++++++++ > >> drivers/misc/fastrpc/Makefile | 2 ++ > >> drivers/misc/{ => fastrpc}/fastrpc.c | 0 > >> 6 files changed, 21 insertions(+), 14 deletions(-) > >> create mode 100644 drivers/misc/fastrpc/Kconfig > >> create mode 100644 drivers/misc/fastrpc/Makefile > >> rename drivers/misc/{ => fastrpc}/fastrpc.c (100%) > > Please consider whether it makes sense to move to drivers/accel instead > > (and possibly writing a better Kconfig entry, specifying that the driver > > is to be used to offload execution to the DSP). > Planning to keep the driver to misc/ only as part of this patch. Moving to accel/ might > introduce some conventions to be followed which might require significant changes > in driver. To me this sounds like "we are trying to avoid following the conventions by hiding in the shadows". > > I'll write more meaningful Kconfig entry in next spin. > -- With best wishes Dmitry
