Prepare to factorize probe function. Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx> --- drivers/gpu/drm/bridge/simple-bridge.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c index 5813a2c4fc5ee..d672e34970e18 100644 --- a/drivers/gpu/drm/bridge/simple-bridge.c +++ b/drivers/gpu/drm/bridge/simple-bridge.c @@ -169,18 +169,19 @@ static const struct drm_bridge_funcs simple_bridge_bridge_funcs = { static int simple_bridge_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct simple_bridge *sbridge; struct device_node *remote; - sbridge = devm_kzalloc(&pdev->dev, sizeof(*sbridge), GFP_KERNEL); + sbridge = devm_kzalloc(dev, sizeof(*sbridge), GFP_KERNEL); if (!sbridge) return -ENOMEM; platform_set_drvdata(pdev, sbridge); - sbridge->info = of_device_get_match_data(&pdev->dev); + sbridge->info = of_device_get_match_data(dev); /* Get the next bridge in the pipeline. */ - remote = of_graph_get_remote_node(pdev->dev.of_node, 1, -1); + remote = of_graph_get_remote_node(dev->of_node, 1, -1); if (!remote) return -EINVAL; @@ -188,29 +189,29 @@ static int simple_bridge_probe(struct platform_device *pdev) of_node_put(remote); if (!sbridge->next_bridge) { - dev_dbg(&pdev->dev, "Next bridge not found, deferring probe\n"); + dev_dbg(dev, "Next bridge not found, deferring probe\n"); return -EPROBE_DEFER; } /* Get the regulator and GPIO resources. */ - sbridge->vdd = devm_regulator_get_optional(&pdev->dev, "vdd"); + sbridge->vdd = devm_regulator_get_optional(dev, "vdd"); if (IS_ERR(sbridge->vdd)) { int ret = PTR_ERR(sbridge->vdd); if (ret == -EPROBE_DEFER) return -EPROBE_DEFER; sbridge->vdd = NULL; - dev_dbg(&pdev->dev, "No vdd regulator found: %d\n", ret); + dev_dbg(dev, "No vdd regulator found: %d\n", ret); } - sbridge->enable = devm_gpiod_get_optional(&pdev->dev, "enable", + sbridge->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW); if (IS_ERR(sbridge->enable)) - return dev_err_probe(&pdev->dev, PTR_ERR(sbridge->enable), + return dev_err_probe(dev, PTR_ERR(sbridge->enable), "Unable to retrieve enable GPIO\n"); /* Register the bridge. */ sbridge->bridge.funcs = &simple_bridge_bridge_funcs; - sbridge->bridge.of_node = pdev->dev.of_node; + sbridge->bridge.of_node = dev->of_node; sbridge->bridge.timings = sbridge->info->timings; drm_bridge_add(&sbridge->bridge); -- 2.34.1