On Wed, Jun 12, 2024 at 11:47:05PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Export drm_plane_has_format() so that drivers can use it. > > Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/drm_crtc_internal.h | 2 -- > drivers/gpu/drm/drm_plane.c | 1 + > include/drm/drm_plane.h | 2 ++ > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h > index cdd60f2a4052..1f73b8d6d750 100644 > --- a/drivers/gpu/drm/drm_crtc_internal.h > +++ b/drivers/gpu/drm/drm_crtc_internal.h > @@ -272,8 +272,6 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, > /* drm_plane.c */ > int drm_plane_register_all(struct drm_device *dev); > void drm_plane_unregister_all(struct drm_device *dev); > -bool drm_plane_has_format(struct drm_plane *plane, > - u32 format, u64 modifier); > struct drm_mode_rect * > __drm_plane_get_damage_clips(const struct drm_plane_state *state); > > diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c > index 268aa2299df5..a51d4dd3f7de 100644 > --- a/drivers/gpu/drm/drm_plane.c > +++ b/drivers/gpu/drm/drm_plane.c > @@ -906,6 +906,7 @@ bool drm_plane_has_format(struct drm_plane *plane, > > return true; > } > +EXPORT_SYMBOL(drm_plane_has_format); Kerneldoc please, since this is now part of the driver api. With that on the first two patches: Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > static int __setplane_check(struct drm_plane *plane, > struct drm_crtc *crtc, > diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h > index 9507542121fa..dd718c62ac31 100644 > --- a/include/drm/drm_plane.h > +++ b/include/drm/drm_plane.h > @@ -972,6 +972,8 @@ static inline struct drm_plane *drm_plane_find(struct drm_device *dev, > #define drm_for_each_plane(plane, dev) \ > list_for_each_entry(plane, &(dev)->mode_config.plane_list, head) > > +bool drm_plane_has_format(struct drm_plane *plane, > + u32 format, u64 modifier); > bool drm_any_plane_has_format(struct drm_device *dev, > u32 format, u64 modifier); > > -- > 2.44.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
