>
> -----Original Message-----
From: Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>
Sent: Friday, June 14, 2024 12:46 PM
To: Cavitt, Jonathan <jonathan.cavitt@xxxxxxxxx>
Cc: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>; intel-gfx <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>; dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; Harrison, John C <john.c.harrison@xxxxxxxxx>
Subject: Re: [PATCH] drm/i915/gt/uc: Fix typo in comment
>
> On Fri, Jun 14, 2024 at 03:23:54PM +0000, Cavitt, Jonathan wrote:
> > -----Original Message-----
> > From: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
> > Sent: Friday, June 14, 2024 8:22 AM
> > To: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
> > Cc: intel-gfx <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>; dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; Harrison, John C <john.c.harrison@xxxxxxxxx>; Cavitt, Jonathan <jonathan.cavitt@xxxxxxxxx>
> > Subject: Re: [PATCH] drm/i915/gt/uc: Fix typo in comment
> > >
> > > I guess sparse and potential CI errors won't minimally relate to
> > > this patch.
> >
> > Yeah, I don't see how a change to a comment could ever be related
> > to any CI errors:
> >
> > Reviewed-by: Jonathan Cavitt
>
> Please ensure you use the full line.
> 1. People don't have to go to the header of your email to get your email.
> 2. People might not be entirely sure of your choice of email. Please notice that
> even on Intel many folks have @intel.com and @linux.intel.com and sometimes although
> responding from one, they use the other to sign things.
> 3. Tooling! (b4, patchwork, etc) There are many tools that get these tags directly
> from the email response and by using partial one you can complicate things.
>
> If you also allow one advice, try to use a terminal mail client like mutt and
> open the replies in your favorite editor and add macros there to add your lines
> based on shortcuts... For instance, on my case I use mutt+emacs and I just hit
> Ctrl+c-rev and that adds my full rv-b tag in the response.
>
Whoops!
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@xxxxxxxxx>
-Jonathan Cavitt
> Thanks,
> Rodrigo.
>
> > -Jonathan Cavitt
> >
> > >
> > > Adding also Jonathan in Cc :-)
> > >
> > > Thanks,
> > > Andi
> > >
> > > On Fri, Jun 14, 2024 at 12:28:37AM +0200, Andi Shyti wrote:
> > > > Replace "dynmically" with "dynamically".
> > > >
> > > > Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
> > > > Cc: John Harrison <John.C.Harrison@xxxxxxxxx>
> > > > ---
> > > > drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
> > > > index 14797e80bc92..263c9c3f6a03 100644
> > > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
> > > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
> > > > @@ -295,7 +295,7 @@ struct guc_update_scheduling_policy_header {
> > > > } __packed;
> > > >
> > > > /*
> > > > - * Can't dynmically allocate memory for the scheduling policy KLV because
> > > > + * Can't dynamically allocate memory for the scheduling policy KLV because
> > > > * it will be sent from within the reset path. Need a fixed size lump on
> > > > * the stack instead :(.
> > > > *
> > > > --
> > > > 2.45.1
> > >
>
