Re: [PATCH REPOST] drm/ttm/tests: Let ttm_bo_test consider different ww_mutex implementation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2024-06-13 14:33:51 [+0200], Christian König wrote:
> > Provide ww_mutex_base_lock() which points to the correct function for
> > PREEMPT_RT and non-PREEMPT_RT builds.
> 
> In general good that somebody is looking into this, but I can't even judge
> why ww_mutex would use rt_mutex in the first place.

as noted in commit message, this is already done in
lib/locking-selftest.c
The base mutex of struct ww_mutex is WW_MUTEX_BASE which is defined as

| #ifndef CONFIG_PREEMPT_RT
| #define WW_MUTEX_BASE                   mutex
…
| #else
| #define WW_MUTEX_BASE                   rt_mutex
…
| #endif

this is all in-tree.

> So I don't feel well reviewing this.
> 
> Regards,
> Christian.

Sebastian




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux