On 11/06/2024 23:12, Doug Anderson wrote:
Hi,
On Tue, Jun 11, 2024 at 2:10 PM Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxx> wrote:
On Tue, Jun 11, 2024 at 08:57:48AM -0700, Doug Anderson wrote:
Hi,
On Tue, Jun 11, 2024 at 7:44 AM Tejas Vipin <tejasvipin76@xxxxxxxxx> wrote:
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce
mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
("drm/mipi-dsi: wrap more functions for streamline handling") for the
sony tulip truly nt35521 panel.
Signed-off-by: Tejas Vipin <tejasvipin76@xxxxxxxxx>
---
Changes in v2:
- Fix patch format
- Fix code style
v1: https://lore.kernel.org/all/485eef24-ddad-466a-a89f-f9f226801bb7@xxxxxxxxx/
---
.../panel/panel-sony-tulip-truly-nt35521.c | 435 +++++++++---------
1 file changed, 209 insertions(+), 226 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c b/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c
index 6d44970dccd9..5a050352c207 100644
--- a/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c
+++ b/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c
@@ -44,248 +44,231 @@ static void truly_nt35521_reset(struct truly_nt35521 *ctx)
static int truly_nt35521_on(struct truly_nt35521 *ctx)
{
struct mipi_dsi_device *dsi = ctx->dsi;
- struct device *dev = &dsi->dev;
- int ret;
+
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
It's not a huge deal, but normally in the kernel all the variable
declarations are cuddled together. AKA no blank line between the
declaration of "dsi" and the declaration of "dsi_ctx". It would be
awesome if you could send a v3 fixing that. When you send v3, feel
free to add this above your own Signed-off-by:
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
...with that, the patch will probably sit on the mailing lists for a
week or two and then get applied. Neil may want to apply it, but if
he's busy I can do it too.
I believe you were planning on tackling some more of the panels. Since
you're still getting started sending patches, maybe keep it to a
smaller batch for now and send another 10 or so? Probably best to keep
it as one panel driver per patch.
-Doug
Do we want to delay this until the mipi_dsi_msleep() is fixed?
Yeah, that's a good point. I saw the mipi_dsi_msleep() problem after I
reviewed this patch, but you're right that it should be fixed first.
Yeah it should wait after mipi_dsi_msleep is fixed.
Neil
-Doug
