Re: [PATCH 2/2] drm/bridge: tc358767: Add configurable default preemphasis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/4/24 11:49 AM, Alexander Stein wrote:

Hi,

@@ -2372,6 +2392,21 @@ static int tc_probe_edp_bridge_endpoint(struct tc_data *tc)
  		tc->bridge.ops |= DRM_BRIDGE_OP_DETECT;
  	tc->bridge.ops |= DRM_BRIDGE_OP_EDID;
+ port = of_graph_get_port_by_id(dev->of_node, 2);
+	if (!port)
+		return 0;
+
+	of_property_read_u8_array(port, "toshiba,pre-emphasis",
+				  tc->pre_emphasis,
+				  ARRAY_SIZE(tc->pre_emphasis));

This doesn't match the bindings. Bindings say it's a property of the
endpoint, not the port. Additionally it's uint32-array, not uint8-array.

It should be u8. Moved to endpoint parsing in V2, thanks.



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux