Re: [PATCH 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/3/24 2:18 PM, Alexander Stein wrote:
Hi Marek,

Hi,

Am Freitag, 31. Mai 2024, 22:39:49 CEST schrieb Marek Vasut:
This line_pixel_subtract is no longer needed now that the bridge can
request and obtain specific pixel clock on input to the bridge, with
clock frequency that matches the Pixel PLL frequency.

The line_pixel_subtract is now always 0, so drop it entirely.

The line_pixel_subtract was not reliable as it never worked when the
Pixel PLL and input clock were off just so that the required amount
of pixels to subtract would not be whole integer.

I think this is based on [1], no?

It is.

I was wondering because it was not stated.

I thought [1] was already applied, but it seems it was only RBd.

I can either apply [1] and then add this on top, so the two commits can be reverted separately if this one breaks something, or squash [1] into this patch and send V2. Which one do you prefer ?

The [1] fixes a real nasty issue with DPI output which causes visible image corruption, so I would like to have [1] in, but it is obviously not perfect.



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux