Hi Jayesh, > > + > > static const struct drm_bridge_funcs sii902x_bridge_funcs = { > > .attach = sii902x_bridge_attach, > > .mode_set = sii902x_bridge_mode_set, > > @@ -516,6 +529,7 @@ static const struct drm_bridge_funcs sii902x_bridge_funcs = { > > .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > > .atomic_get_input_bus_fmts = sii902x_bridge_atomic_get_input_bus_fmts, > > .atomic_check = sii902x_bridge_atomic_check, > > + .mode_valid = sii902x_bridge_mode_valid, As you have the possibility to test the driver, it would be nice with a follow-up patch that replaces the use of enable() / disable() with the atomic counterparts. enable() / disable() are deprecated, so it is nice to reduce their use. Sam