On Tue, May 28, 2024 at 05:01:31PM +0530, Devarsh Thakkar wrote: > On 28/05/24 02:08, Andy Shevchenko wrote: > > On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote: > >> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote: ... > >>> +MODULE_LICENSE("GPL"); > >> > >> modpost validator won't be happy about this, i.e. missing MODULE_DESCRIPTION(). > > > > And obviously + module.h in the inclusion block. > > The module.h is already included under include/kunit/test.h and that's the > reason compiler did not give any error. But I can still include it under > math.h for better readability as you suggested as anyway compiler will not > re-include if already included by another header file. Please do as it will be in line with IWYU principle. > Also I see we were missing a dependency between math_kunit and kunit modules, > so adding a dependency there too. Thank you. -- With Best Regards, Andy Shevchenko