Le 28/05/24 - 10:08, Bruno Rocha Levi a écrit : > From: Bruno Rocha Levi <brunolevilevi@xxxxxxxxx> > > This change fixes a warning from checkpatch, it improves readability of a > comment that was previously misaligned, by ensuring the trailing */ is on > the same line as the opening /*. Hi, Do you mean same column? Maybe in the same patch, also add the missing first empty line in the comment [1]: /* * FIXME: [...] */ https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting Thanks, Louis Chauvet > Co-developed-by: Lucas Antonio <lucasantonio.santos@xxxxxx> > Signed-off-by: Lucas Antonio <lucasantonio.santos@xxxxxx> > Signed-off-by: Bruno Rocha Levi <brunolevilevi@xxxxxx> > --- > drivers/gpu/drm/vkms/vkms_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > index dd0af086e..e8612759a 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.c > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > @@ -166,7 +166,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev) > dev->mode_config.cursor_height = 512; > /* FIXME: There's a confusion between bpp and depth between this and > * fbdev helpers. We have to go with 0, meaning "pick the default", > - * which ix XRGB8888 in all cases. */ > + * which ix XRGB8888 in all cases. > + */ > dev->mode_config.preferred_depth = 0; > dev->mode_config.helper_private = &vkms_mode_config_helpers; > > -- > 2.45.1 > -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
