On Mon, 27 May 2024, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> On Mon, May 27, 2024 at 12:43 PM Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
>>
>> Use the mem_is_zero() helper where possible.
>
> ...
>
>> - if (memchr_inv(guid, 0, 16) == NULL) {
>> + if (mem_is_zero(guid, 16)) {
>> tmp64 = get_jiffies_64();
>> memcpy(&guid[0], &tmp64, sizeof(u64));
>> memcpy(&guid[8], &tmp64, sizeof(u64));
>
> What is the type of guid? Shouldn't it be guid_t with the respective
> guid_is_null()
I can leave out these parts of the patch.
BR,
Jani.
>
> ...
>
>> - if (memchr_inv(guid, 0, 16))
>> + if (!mem_is_zero(guid, 16))
>> return true;
>
> Ditto.
--
Jani Nikula, Intel
