On Mon, May 20, 2024 at 12:57:36PM +0000, Dr. David Alan Gilbert wrote:
> * Dmitry Baryshkov (dmitry.baryshkov@xxxxxxxxxx) wrote:
> > On Sun, May 19, 2024 at 10:43:44PM +0000, Dr. David Alan Gilbert wrote:
> > > * Dmitry Baryshkov (dmitry.baryshkov@xxxxxxxxxx) wrote:
> > > > On Sat, May 18, 2024 at 12:24:27AM +0100, linux@xxxxxxxxxxx wrote:
> > > > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > > > >
> > > > > 'bridge_init' is unused, I think following:
> > > > > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
> > > > > (which is where a git --follow finds it)
> > > > > Remove it.
> > > >
> > > > Please rephrase the commit message following guidelines in
> > > > Documentation/process. Use Fixes tags if suitable.
> > >
> > > I specifically don't want to use Fixes in these set because
> > > there's no need for someone to backport this to older
> > > kernels that use the original, and many backporters
> > > use 'Fixes' as an automated means to find stuff they should
> > > backport.
> > >
> > > Other than that, is there something specific you think I've
> > > missed?
> >
> > It's not about missing things. It's about a way it is written.
> > Consider something like:
> >
> > The commit aaaaaaa ("drm/bridge: foo bar") has dropped all the users of
> > the struct bridge_init from the exynos_dp_core, while retainng unused
> > structure definition. Later on the driver was reworked and the
> > definition migrated to the analogix_dp driver. Remove unused struct
> > bridge_init definition.
>
> OK, v2 sent with text close to that.
>
> >
> > >
> > > (I'm also purposely being less certain here, because --follow
> > > is showing it in a ptn3460 and I don't quite follow
> > > why that changes it here).
> >
> > The mentioned commit is a correct one. Historically exynos_dp_core had
> > been creating the ptn3460 bridge manually. Later on this was fixed in
> > the ptn3640 driver and the code was dropped from exynos_dp_core.
>
> Ah OK; remember I don't know the actual structure of these devices
> or the history.
It's all a part of the git history. I've just read it aloud for you.
--
With best wishes
Dmitry
