On Fri, 17 May 2024, Sefa Eyeoglu <contact@xxxxxxxxxxxxx> wrote: > On Fri, 2024-05-17 at 16:52 +0200, Philipp Zabel wrote: >> On Fr, 2024-05-17 at 16:09 +0200, Sefa Eyeoglu wrote: >> > The Bigscreen Beyond VR headset is a non-desktop output and should >> > be >> > marked as such using an EDID quirk. >> > >> > Closes https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/39 >> >> From the EDID posted there, it looks like the quirk should not be >> necessary? >> >> The quoted DisplayID extension block correctly marks this as an HMD: >> >> "Display Product Primary Use Case: Head-mounted Virtual Reality >> (VR) display" >> >> The update_displayid_info() function in drm_edid.c should use this >> information to set the non_desktop flag already. Doesn't this work as >> expected? >> >> >> regards >> Philipp > > I see. > > The only potential reason I can come up with is that the DisplayID > block is incomplete. > > $ edid-decode --check > Failures: > > Block 0, Base EDID: > Standard Timings: Missing preferred timing. > EDID: > DisplayID: Missing DisplayID Product Identification Data Block. > DisplayID: Missing DisplayID Display Parameters Data Block. > DisplayID: Missing DisplayID Display Interface Features Data Block. > > EDID conformity: FAIL I've commented on the bug, but I don't think these should matter. We should be able to deduce the primary use from the DisplayID header. BR, Jani. -- Jani Nikula, Intel