On Fri, May 17, 2024 at 1:27 PM Tim Van Patten <timvp@xxxxxxxxxxxx> wrote: > > > Fair enough, but this is also the only gfx9 APU which defaults to > > noretry=1, all of the rest are dGPUs. I'd argue it should align with > > the other GFX9 APUs or they should all enable noretry=1. > > Do you mean we should remove all IP_VERSION(9, X, X) entries from > amdgpu_gmc_noretry_set(), leaving just >= IP_VERSION(10, 3, 0)? No, just take your patch as is. All of the other 9.x IP versions in that check are dGPUs. 9.3.0 was the only APU in that list. Alex
