Re: [PATCH] nouveau/firmware: using dma non-coherent interfaces for fw loading.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dave,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm-tip/drm-tip linus/master v6.9 next-20240513]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dave-Airlie/nouveau-firmware-using-dma-non-coherent-interfaces-for-fw-loading/20240513-144435
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20240513064350.1050994-1-airlied%40gmail.com
patch subject: [PATCH] nouveau/firmware: using dma non-coherent interfaces for fw loading.
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240513/202405132205.FVKltMCq-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240513/202405132205.FVKltMCq-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405132205.FVKltMCq-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/nouveau/nvkm/core/firmware.c:242:12: error: incompatible pointer types passing 'u64 *' (aka 'unsigned long long *') to parameter of type 'dma_addr_t *' (aka 'unsigned int *') [-Werror,-Wincompatible-pointer-types]
                                                   len, &fw->phys,
                                                        ^~~~~~~~~
   include/linux/dma-mapping.h:321:15: note: passing argument to parameter 'dma_handle' here
                   dma_addr_t *dma_handle, enum dma_data_direction dir, gfp_t gfp)
                               ^
   1 error generated.


vim +242 drivers/gpu/drm/nouveau/nvkm/core/firmware.c

   224	
   225	int
   226	nvkm_firmware_ctor(const struct nvkm_firmware_func *func, const char *name,
   227			   struct nvkm_device *device, const void *src, int len, struct nvkm_firmware *fw)
   228	{
   229		fw->func = func;
   230		fw->name = name;
   231		fw->device = device;
   232		fw->len = len;
   233	
   234		switch (fw->func->type) {
   235		case NVKM_FIRMWARE_IMG_RAM:
   236			fw->img = kmemdup(src, fw->len, GFP_KERNEL);
   237			break;
   238		case NVKM_FIRMWARE_IMG_DMA: {
   239			len = ALIGN(fw->len, PAGE_SIZE);
   240	
   241			fw->img = dma_alloc_noncoherent(fw->device->dev,
 > 242							len, &fw->phys,

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux