Hi,
On 5/13/24 13:56, Liu Ying wrote:
On 5/11/24 23:08, Sui Jingfeng wrote:
The check on the existence of bridge->encoder on the implementation layer
of drm bridge driver is not necessary, as it has already been done in the
drm_bridge_attach() function. It is guaranteed that the .encoder member
of the drm_bridge instance is not NULL when various imx_xxx_bridge_attach()
function gets called.
Nit:
ldb_bridge_attach_helper() doesn't follow the fashion of
imx_xxx_bridge_attach(), not even the other bridge attach
functions touched by this patch do.
Right, my bad.
But personally, I think rename it as ldb_bridge_attach() should
enough to express the meaning. :-)
Maybe, reword as
"when various i.MX specific bridge attach functions are
called."
OK, fine.
I will correct the commit message at the next version,
so happy being reviewed. Thanks.
Regards,
Liu Ying
