In it6505_bridge_attach(), the check on the existence of bridge->encoder has already been done in the implementation of drm_bridge_attach(). And it is done before the bridge->funcs->attach function hook is called. Hence, it is guaranteed that the .encoder member of the struct drm_bridge is not NULL when the panel_bridge_attach() is called. There is no need to check the existence of bridge->encoder another time, remove the redundant checking codes "if (!bridge->encoder) { ... }". Signed-off-by: Sui Jingfeng <sui.jingfeng@xxxxxxxxx> --- drivers/gpu/drm/bridge/ite-it6505.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 27334173e911..494030a75dba 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -2881,11 +2881,6 @@ static int it6505_bridge_attach(struct drm_bridge *bridge, return -EINVAL; } - if (!bridge->encoder) { - dev_err(dev, "Parent encoder object not found"); - return -ENODEV; - } - /* Register aux channel */ it6505->aux.drm_dev = bridge->dev; -- 2.43.0