Hi, On Fri, May 10, 2024 at 3:25 PM Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Fri, May 10, 2024 at 02:47:05PM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov > > <dmitry.baryshkov@xxxxxxxxxx> wrote: > > > > > > Add missing error handling for the mipi_dsi_ functions that actually > > > return error code instead of silently ignoring it. > > > > > > Fixes: 069a6c0e94f9 ("drm: panel: Add LG sw43408 panel driver") > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > --- > > > drivers/gpu/drm/panel/panel-lg-sw43408.c | 33 ++++++++++++++++++++++++++------ > > > 1 file changed, 27 insertions(+), 6 deletions(-) > > > > Looks right to me. Only slight nit would be that I'd put this as the > > first patch in the series to make it obvious to anyone backporting it > > to older kernels that it doesn't have any dependencies on the earlier > > patches in the series. It's fairly obvious so this isn't a huge deal, > > but still could be nice. > > Yes. I wanted to emphasise the _multi stuff rather than this fix. I'll > reorder patches for v2. Maybe I should also rebase the series on top of > patches by Cong Yang. WDYT? Sounds good. I think Cong is planning on a V6 to fix the last nit I had on his patch series [1] but otherwise this plan sounds fine to me. [1] https://lore.kernel.org/r/CAHwB_NKtw0AyMgFb4rMFNgr4WF10o9_0pYvbKpnDM45aYma9zg@xxxxxxxxxxxxxx -Doug