On 5/7/24 2:14 AM, Borislav Petkov wrote:
On Mon, May 06, 2024 at 02:52:58PM -0700, Alexey Makhalov wrote:
+#define VMWARE_HYPERVISOR_PORT 0x5658
+#define VMWARE_HYPERVISOR_PORT_HB (VMWARE_HYPERVISOR_PORT | \
+ VMWARE_HYPERVISOR_HB)
You can't help yourself not sneaking in any changes which are not code
movement, can ya?
Indeed! My fault.
The purpose of a sole code movement patch is to ease the review. Not to
have to look at the code movement *and* some *additional* changes which
you've done in-flight. Just because you felt like it. But which is nasty
to review.
Agree. I should not claim it as sole code movement then.
At least moving macros from .c to .h file requires changing
vmware_hypercall_mode variable visibility from static to global.
If you think this type of changes is Ok for sole code movement patch,
then I'll continue following this path. Otherwise, will change patch
description.
Thanks for the patience.
--Alexey
