Hi, Doug &Conor Doug Anderson <dianders@xxxxxxxxxxxx> 于2024年5月8日周三 00:40写道： > > Hi, > > On Tue, May 7, 2024 at 8:14 AM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote: > > > > > > On Tue, 07 May 2024 21:52:28 +0800, Cong Yang wrote: > > > In V1, discussed with Doug and Linus [1], we need break out as separate > > > driver for the himax83102-j02 controller. Beacuse "starry,himax83102-j02" > > > and in this series "BOE nv110wum-l60" "IVO t109nw41" panels use same > > > controller, they have some common CMDS. So add new documentation for > > > this panels. > > > > > > For himax83102-j02 controller, no need 3v3 supply, so remove it. > > > > > > [1]: https://lore.kernel.org/all/CACRpkdbzYZAS0=zBQJUC4CB2wj4s1h6n6aSAZQvdMV95r3zRUw@xxxxxxxxxxxxxx > > > > > > Signed-off-by: Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > --- > > > Chage since V4: > > > > > > - Update commit message and add fallback compatible. > > > > > > V3: https://lore.kernel.org/all/20240424023010.2099949-2-yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx > > > > > > Chage since V3: > > > > > > - Update commit message. > > > > > > V2: https://lore.kernel.org/all/20240422090310.3311429-2-yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx > > > > > > --- > > > .../display/panel/boe,tv101wum-nl6.yaml | 2 - > > > .../bindings/display/panel/himax,hx83102.yaml | 73 +++++++++++++++++++ > > > 2 files changed, 73 insertions(+), 2 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/himax,hx83102.example.dtb: panel@0: compatible:0: 'starry,himax83102-j02, himax,hx83102' does not match '^[a-zA-Z0-9][a-zA-Z0-9,+\\-._/]+$' > > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > > Documentation/devicetree/bindings/display/panel/himax,hx83102.example.dtb: /example-0/dsi/panel@0: failed to match any schema with compatible: ['starry,himax83102-j02, himax,hx83102'] > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240507135234.1356855-2-yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema. > > I think several of your bindings patches have triggered Rob's bot. > Please make sure you're set up to test this yourself and make sure you > run it locally before sending out the next version of your patches. In > general you should get in the habit of running 'make dt_binding_check' > locally before you post any bindings changes. Sorry, I forgot to running 'make dt_binding_check'. Thanks for the correction. > > Thanks! > > -Doug
