Am Freitag, 3. Mai 2024, 23:32:50 CEST schrieb Douglas Anderson: > It's the responsibility of a correctly written DRM modeset driver to > call drm_atomic_helper_shutdown() at shutdown time and that should be > disabling / unpreparing the panel if needed. Panel drivers shouldn't > be calling these functions themselves. > > A recent effort was made to fix as many DRM modeset drivers as > possible [1] [2] [3] and most drivers are fixed now. > > A grep through mainline for compatible strings used by this driver > indicates that it is used by Rockchip boards. The Rockchip driver > appears to be correctly calling drm_atomic_helper_shutdown() so we can > remove the calls. > > [1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@xxxxxxxxxxxx > [2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@xxxxxxxxxxxx > [3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@xxxxxxxxxxxx > > Cc: Chris Zhong <zyw@xxxxxxxxxxxxxx> > Cc: Lin Huang <hl@xxxxxxxxxxxxxx> > Cc: Brian Norris <briannorris@xxxxxxxxxxxx> > Cc: "Heiko Stübner" <heiko@xxxxxxxxx> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> the underlying setup (rockchip-drm with dw-dsi) as well as the change itself is similar to the ltk050h3146w variant, so I don't see how this should behave differently ;-) Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
