Am Freitag, 3. Mai 2024, 23:32:56 CEST schrieb Douglas Anderson: > It's the responsibility of a correctly written DRM modeset driver to > call drm_atomic_helper_shutdown() at shutdown time and that should be > disabling / unpreparing the panel if needed. Panel drivers shouldn't > be calling these functions themselves. > > A recent effort was made to fix as many DRM modeset drivers as > possible [1] [2] [3] and most drivers are fixed now. > > Unfortunately, grepping mainline for this panel's compatible string > shows no hits, so we can't be 100% sure if the DRM modeset driver used > with this panel has been fixed. If it is found that the DRM modeset > driver hasn't been fixed then this patch could be temporarily reverted > until it is. > > [1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@xxxxxxxxxxxx > [2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@xxxxxxxxxxxx > [3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@xxxxxxxxxxxx > > Cc: "Heiko Stübner" <heiko@xxxxxxxxx> > Cc: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> On a rk3588-tiger with WIP DSI patches and this display Tested-by: Heiko Stuebner <heiko@xxxxxxxxx> Before this patch on reboot the system emits [ 181.464230] panel-leadtek-ltk050h3146w fde20000.dsi.0: Skipping disable of already disabled panel [ 181.465056] panel-leadtek-ltk050h3146w fde20000.dsi.0: Skipping unprepare of already unprepared panel after applying this patch, those lines are gone. Also the patch itself looks good Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
