On Wed, May 1, 2024 at 5:43 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > Consensus on the mailing lists is that panels shouldn't use a table of > init commands but should instead use init functions. With the recently > introduced mipi_dsi_dcs_write_seq_multi() this is not only clean/easy > but also saves space. Measuring before/after this change: > > $ scripts/bloat-o-meter \ > .../before/panel-ilitek-ili9882t.ko \ > .../after/panel-ilitek-ili9882t.ko > add/remove: 3/2 grow/shrink: 0/2 up/down: 6834/-8177 (-1343) > Function old new delta > starry_ili9882t_init - 6152 +6152 > starry_ili9882t_init.d - 678 +678 > ili9882t_disable.d - 4 +4 > ili9882t_disable 260 228 -32 > ili9882t_prepare 540 396 -144 > .compoundliteral 681 - -681 > starry_ili9882t_init_cmd 7320 - -7320 > Total: Before=11928, After=10585, chg -11.26% > > Let's do the conversion. > > Since we're touching all the tables, let's also convert hex numbers to > lower case as per kernel conventions. > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Thanks for doing this Doug, everything is starting to look much better after this series, and I hope we can keep Chromium display drivers looking this good going forward. Yours, Linus Walleij
