Re: [PATCH 1/1] drm: arm: display: komeda: komeda_crtc: use 'time_left' variable with wait_for_completion_timeout()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >  	/* wait the flip take affect.*/
> > -	timeout = wait_for_completion_timeout(flip_done, HZ);
> > -	if (timeout == 0) {
> > +	time_left = wait_for_completion_timeout(flip_done, HZ);
> > +	if (time_left == 0) {
> 
> Honestly, if the name of the variable is confusing I would get rid of it completely. Can you
> send a patch that removes the timeout variable and here just does:
> 
> 	if (wait_for_completion_timeout(flip_done, HZ) == 0) {

Can do. I think, though, that using 'time_left' is still easier to
understand. However, this code block is simple enough and it is your
driver, so I'll send v2 later.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux