Hi, On Thu, May 2, 2024 at 1:23 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Wed, May 1, 2024 at 5:43 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > > Through a cooperative effort between Hsin-Yi Wang and Dmitry > > Baryshkov, we have realized the dev_err() in the > > mipi_dsi_*_write_seq() macros was causing quite a bit of bloat to the > > kernel. Let's hoist this call into drm_mipi_dsi.c by adding a "chatty" > > version of the functions that includes the print. While doing this, > > add a bit more comments to these macros making it clear that they > > print errors and also that they return out of _the caller's_ function. > > This doesn't really explain why this takes so much less space. > > Please add some explanation like that "the macro gets inlined > and thus the error report string gets inlined into every call to > mipi_dsi_dcs_write_seq() and mipi_dsi_generic_write_seq(), > by using a call to a "chatty" function, the usage is reduced to one > string in the chatty function and a function call at the invoking > site". > > With some explanation like that +/- added in: > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Sure. I'll plan on not sending out a v4 (unless I need to for some other reason) and I can just add your wording in when applying. Yell if you want me to do something different. -Doug
