On Thu, Apr 25, 2024 at 06:04:50PM +0300, Andy Shevchenko wrote: > On Thu, Apr 25, 2024 at 04:58:06PM +0200, Maxime Ripard wrote: > > Hi, > > > > On Thu, Apr 25, 2024 at 03:42:07PM +0300, Andy Shevchenko wrote: > > > First of all, the driver was introduced when it was already > > > two drivers available for Ilitek 9341 panels. > > > > > > Second, the most recent (fourth!) driver has incorporated this one > > > and hence, when enabled, it covers the provided functionality. > > > > > > Taking into account the above, remove duplicative driver and make > > > maintenance and support eaiser for everybody. > > > > > > Also see discussion [1] for details about Ilitek 9341 duplication > > > code. > > > > > > Link: https://lore.kernel.org/r/ZXM9pG-53V4S8E2H@xxxxxxxxxxxxxxxxxx [1] > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > I think it should be the other way around and we should remove the > > mipi-dbi handling from panel/panel-ilitek-ili9341.c > > Then please do it! I whining already for a few years about this. I have neither the hardware nor the interest to do so. Seems it looks like you have plenty of the latter at least, I'm sure you'll find some time to tackle this. Maxime
Attachment:
signature.asc
Description: PGP signature
