> -----Original Message----- > From: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > Sent: Thursday, April 25, 2024 11:36 PM > To: Klymenko, Anatoliy <Anatoliy.Klymenko@xxxxxxx> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; kernel test robot <lkp@xxxxxxxxx>; Laurent > Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>; Maarten Lankhorst > <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard > <mripard@xxxxxxxxxx>; Thomas Zimmermann <tzimmermann@xxxxxxx>; > David Airlie <airlied@xxxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; > Simek, Michal <michal.simek@xxxxxxx> > Subject: Re: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation > error > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On 26/04/2024 04:46, Anatoliy Klymenko wrote: > > Fix W=1 clang 19 compilation error in > zynqmp_disp_layer_drm_formats(). > > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4oZXvHD2- > lkp@xxxxxxxxx/ > > --- > > This is missing your signed-off-by. > > Tomi Thank you! > > > drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c > b/drivers/gpu/drm/xlnx/zynqmp_disp.c > > index 423f5f4943cc..c9fb432d4cbd 100644 > > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > > @@ -981,7 +981,7 @@ u32 *zynqmp_disp_layer_drm_formats(struct > zynqmp_disp_layer *layer, > > unsigned int i; > > u32 *formats; > > > > - if (WARN_ON(!layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE)) { > > + if (WARN_ON(layer->mode != ZYNQMP_DPSUB_LAYER_NONLIVE)) { > > *num_formats = 0; > > return NULL; > > } > >
