On 2024/4/25 03:37, Konrad Dybcio wrote: > On 4/24/24 17:29, Xilin Wu via B4 Relay wrote: >> From: Junhao Xie <bigfoot@xxxxxxxxxxx> >> >> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller. >> >> Signed-off-by: Junhao Xie <bigfoot@xxxxxxxxxxx> >> --- >[...] >> + return sn3112_write_reg(priv, SN3112_REG_PWM_EN + reg, >> + priv->pwm_en_reg[reg]); > > This looks like a weird reimplementation of regmap_update_bits > We cannot use regmap_update_bits because this chip does not support read command. It will discard all read command. >> +} >> + [...] > > devm_pwmchip_add? > > Konrad Thank you for your reply, I will fix them.
