On Sun, Apr 21, 2024 at 06:40:48AM +0530, Dharma Balasubiramani wrote: > Add a new LVDS controller driver for sam9x7 which does the following: > - Prepares and enables the LVDS Peripheral clock > - Defines its connector type as DRM_MODE_CONNECTOR_LVDS and adds itself > to the global bridge list. > - Identifies its output endpoint as panel and adds it to the encoder > display pipeline > - Enables the LVDS serializer > > Signed-off-by: Manikandan Muralidharan <manikandan.m@xxxxxxxxxxxxx> > Signed-off-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx> > Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@xxxxxxxxxxxxx> > --- > Changelog > v7 -> v8 > - Assign ret variable properly before checking it for err. > v6 -> v7 > - Remove setting encoder type from bridge driver. > - Drop clk_disable() from pm_runtime_get_sync() error handling. > - Use devm_clk_get() instead of prepared version. > - Hence use clk_prepare_enable() and clk_disable_unprepare(). > - Use devm_drm_of_get_bridge() instead of devm_drm_panel_bridge_add(). > - Add error check for devm_pm_runtime_enable(). > - Use dev_err() instead of DRM_DEV_ERROR() as it is deprecated. > - Add missing Acked-by tag. > v5 -> v6 > - No Changes. > v4 -> v5 > - Drop the unused variable 'format'. > - Use DRM wrapper for dev_err() to maintain uniformity. > - return -ENODEV instead of -EINVAL to maintain consistency with other DRM > bridge drivers. > v3 -> v4 > - No changes. > v2 ->v3 > - Correct Typo error "serializer". > - Consolidate get() and prepare() functions and use devm_clk_get_prepared(). > - Remove unused variable 'ret' in probe(). > - Use devm_pm_runtime_enable() and drop the mchp_lvds_remove(). > v1 -> v2 > - Drop 'res' variable and combine two lines into one. > - Handle deferred probe properly, use dev_err_probe(). > - Don't print anything on deferred probe. Dropped print. > - Remove the MODULE_ALIAS and add MODULE_DEVICE_TABLE(). > - symbol 'mchp_lvds_driver' was not declared. It should be static. > --- > drivers/gpu/drm/bridge/Kconfig | 7 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/microchip-lvds.c | 229 ++++++++++++++++++++++++ > 3 files changed, 237 insertions(+) > create mode 100644 drivers/gpu/drm/bridge/microchip-lvds.c > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
