On 19/04/24 14:41, Maxime Ripard wrote: > On Fri, Apr 19, 2024 at 02:28:23PM +0530, Aravind Iddamsetty wrote: >> In scenarios where drm_dev_put is directly called by driver we want to >> release devm_drm_dev_init_release action associated with struct >> drm_device. >> >> v2: Directly expose the original function, instead of introducing a >> helper (Rodrigo) >> >> Cc: Thomas Hellstr_m <thomas.hellstrom@xxxxxxxxxxxxxxx> >> Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> >> >> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> >> Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@xxxxxxxxxxxxxxx> >> --- >> drivers/gpu/drm/drm_drv.c | 6 ++++++ >> include/drm/drm_drv.h | 2 ++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c >> index 243cacb3575c..ba60cbb0725f 100644 >> --- a/drivers/gpu/drm/drm_drv.c >> +++ b/drivers/gpu/drm/drm_drv.c >> @@ -714,6 +714,12 @@ static int devm_drm_dev_init(struct device *parent, >> devm_drm_dev_init_release, dev); >> } >> >> +void devm_drm_dev_release_action(struct drm_device *dev) >> +{ >> + devm_release_action(dev->dev, devm_drm_dev_init_release, dev); >> +} >> +EXPORT_SYMBOL(devm_drm_dev_release_action); > Again, this needs to be documented. sorry I missed your earlier email, will address this. Thanks, Aravind. > > Maxime