On 18/04/2024 16:01, Johan Adolfsson wrote:
> Add generic panel-dsi panel, similar to panel-dpi that can have it's
> timing, lanes and flags overridden by devicetree.
> Add some dev_err() and dev_warn() calls.
>
...
> /* sentinel */
> }
> @@ -4992,17 +5051,28 @@ static int panel_simple_dsi_probe(struct mipi_dsi_device *dsi)
> return -ENODEV;
>
> err = panel_simple_probe(&dsi->dev, &desc->desc);
> + if (err)
> + dev_err(&dsi->dev, "%s: err %i\n", __func__, err);
This looks like debugging code.
> +
> + if (desc == &panel_dsi) {
> + struct panel_simple *panel = mipi_dsi_get_drvdata(dsi);
> + /* Handle the generic panel-dsi binding */
> + err = panel_dsi_probe(&dsi->dev, panel);
> + }
> +
> if (err < 0)
> return err;
>
> dsi->mode_flags = desc->flags;
> dsi->format = desc->format;
> dsi->lanes = desc->lanes;
> + of_property_read_u32(dsi->dev.of_node, "lanes", &dsi->lanes);
Is this defined in the binding?
>
> err = mipi_dsi_attach(dsi);
> if (err) {
> struct panel_simple *panel = mipi_dsi_get_drvdata(dsi);
>
> + dev_err(&dsi->dev, "probe attach err: %i", err);
Do not introduce unrelated code changes.
Best regards,
Krzysztof
