Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



April 8, 2024 at 8:04 PM, "Ville Syrjala" <ville.syrjala@xxxxxxxxxxxxxxx mailto:ville.syrjala@xxxxxxxxxxxxxxx?to=%22Ville%20Syrjala%22%20%3Cville.syrjala%40linux.intel.com%3E > wrote:

> 
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> __iowmb() isn't available on most architectures. Make
> its use optional so that the driver can be built on
> other architectures with COMPILE_TEST=y.
> 
> Cc: Jyri Sarha <jyri.sarha@xxxxxx>
> Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

Acked-by: Jyri Sarha <jyri.sarha@xxxxxx>

Thanks,
Jyri

> ---
> drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> index f90e2dc3457c..44e4ada30fba 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> @@ -125,7 +125,9 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
> #if defined(iowrite64) !defined(iowrite64_is_nonatomic)
>  iowrite64(data, addr);
> #else
> +#ifdef __iowmb
>  __iowmb();
> +#endif
>  /* This compiles to strd (=64-bit write) on ARM7 */
>  *(volatile u64 __force *)addr = __cpu_to_le64(data);
> #endif
> -- 
> 2.43.2
>




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux