On 4/6/24 04:56, Dmitry Baryshkov wrote:
On Fri, Apr 05, 2024 at 10:41:31AM +0200, Konrad Dybcio wrote:
From: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
Usually, speedbin 0 is the "super SKU", a.k.a the one which can clock
the highest. Falling back to it when things go wrong is largely
suboptimal, as more often than not, the top frequencies are not
supposed to work on other bins.
Isn't it better to just return an error here instead of trying to guess
which speedbin to use?
Not sure. I'd rather better compatibility for e.g. booting up a new
laptop with just dt.
If that's not the case, I think the commit should be expanded with
actually setting default_speedbin for the existing GPUs.
I think that should be addressed, although separately.
Konrad
