Hi, On Mon, Mar 25, 2024 at 5:07 PM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote: > > On Mon, Mar 25, 2024 at 2:57 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > > > If we're using the AUX channel for eDP backlight and it fails to probe > > for some reason, let's _not_ fail the panel probe. > > > > At least one case where we could fail to init the backlight is because > > of a dead or physically missing panel. As talked about in detail in > > the earlier patch in this series, ("drm/panel-edp: If we fail to > > powerup/get EDID, use conservative timings"), this can cause the > > entire system's display pipeline to fail to come up and that's > > non-ideal. > > > > If we fail to init the backlight for some transitory reason, we should > > dig in and see if there's a way to fix this (perhaps retries?). Even > > in that case, though, having a panel whose backlight is stuck at 100% > > (the default, at least in the panel Samsung ATNA33XC20 I tested) is > > better than having no panel at all. > > > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > Reviewed-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> Pushed to drm-misc-next: b48ccb18e642 drm-panel: If drm_panel_dp_aux_backlight() fails, don't fail panel probe