On 4/2/24 16:28, Zack Rusin wrote: > > @@ -541,6 +518,8 @@ static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit) > dev_priv->implicit_placement_property, > 1); > > + vmw_du_init(&ldu->base); > + > return 0; > > err_free_unregister: > @@ -905,6 +900,9 @@ static int vmw_sou_init(struct vmw_private *dev_priv, unsigned unit) > dev->mode_config.suggested_x_property, 0); > drm_object_attach_property(&connector->base, > dev->mode_config.suggested_y_property, 0); > + > + vmw_du_init(&sou->base); > + > return 0; > > err_free_unregister: > @@ -1575,6 +1576,9 @@ static int vmw_stdu_init(struct vmw_private *dev_priv, unsigned unit) > dev->mode_config.suggested_x_property, 0); > drm_object_attach_property(&connector->base, > dev->mode_config.suggested_y_property, 0); > + > + vmw_du_init(&stdu->base); > + > return 0; > > err_free_unregister: Shouldn't calls to vmw_du_init() be behind an if(vkms_enabled) condition? Thanks, Maaz Mombasawala <maaz.mombasawala@xxxxxxxxxxxx>
