On 30/03/2024 04:59, Dmitry Baryshkov wrote: > From: Sumit Semwal <sumit.semwal@xxxxxxxxxx> > > LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel present on Google Pixel 3 > phones. ... Few nits, which could be ignored, and one thing which is blocking - missing example. > + > +maintainers: > + - Caleb Connolly <caleb.connolly@xxxxxxxxxx> > + > +description: | Do not need '|' unless you need to preserve formatting. > + This panel is used on the Pixel 3, it is a 60hz OLED panel which > + required DSC (Display Stream Compression) and has rounded corners. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + items: > + - const: lg,sw43408 > + > + reg: true > + port: true > + vddi-supply: true > + vpnl-supply: true > + reset-gpios: true > + > +additionalProperties: false This goes after required: > + > +required: > + - compatible > + - vddi-supply > + - vpnl-supply > + - reset-gpios Please add example DTS. Best regards, Krzysztof