On Thu, Aug 22, 2013 at 07:33:43AM -0400, Rob Clark wrote: > On Thu, Aug 22, 2013 at 2:53 AM, Jean-Francois Moine <moinejf@xxxxxxx> wrote: > > On Wed, 21 Aug 2013 23:36:05 +0100 > > Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > > > >> > AFAIK, the TI boards have no "pin-swapped", nor has the Cubox (there is > >> > no need to set the bit CFG_GRA_SWAPRB of the register LCD_SPU_DMA_CTRL0 > >> > of the Dove lcd for RGB or YUV formats). > >> > > >> > Which board needs a special VIP configuration? > >> > >> If you run the NXP driver, and then run this driver, things get messed > >> up - which has already been covered months ago when this patch was first > >> brought up. > >> > >> It's there to ensure that the TDA998x is correctly configured no matter > >> what it's previous state is, and prevent the thing being fragile as hell. > > > > The NXP driver will never go to the mainline, so, I don't see the > > problem. If you want to use it to test some other drivers, you should > > better patch it instead of adding useless code in the TDA998x driver. > > I don't think it really matters for the end user if NXP isn't > mainline. If they are jumping between vendor kernel and mainline, and > inheriting some state left over from the NXP driver in vendor kernel, > it makes debugging very confusing. It would be less of an issue if a > warm reset actually reset the tda998x part, but that is not the case, > it is better to rely less on the hw state when the driver is loaded, > IMHO. Absolutely right, thanks for backing up what I've said. I've done exactly that - switching between the NXP driver and the mainline driver to debug other problems, and not having the TDA998x setup correctly just makes the job much harder and time consuming. I keep both drivers available in my internal git tree so that I can switch between them when necessary. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
